🎉 @huggingface/widgets #297
Conversation
coyotte508
changed the title
|
cc @mishig25 |
There was a problem hiding this comment.
the whole interfaces folder should be in its own package IMO
There was a problem hiding this comment.
yes there's already a part in @huggingface/tasks but we can probably move more in @huggingface/widgets-data
There was a problem hiding this comment.
it's more central than widgets-data, i had an idea for a name, let me try to find it again
There was a problem hiding this comment.
aarg can't find it, but what about:
@huggingface/pipeline-types
or
@huggingface/interfaces
or
@huggingface/types (this one prob looks weird)
Also ping @osanseviero on naming the root package that will include those files:
WDYT?
There was a problem hiding this comment.
Libraries are used in @huggingface/tasks (because TASKS_DATA contains some libraries), so we should probably move Libraries nad LibrariesToTask to @huggingface/tasks (and maybe rename @huggingface/tasks to something else?) - ModelLibrary was already moved there for now.
The remaining Types.ts, DefaultWidget.ts and InferenceDisplayability.ts are all related to the inference widget
There was a problem hiding this comment.
Types.ts is more central than widgets, which should be mostly self-contained
Otherwise let's move those files to @huggingface/tasks then. I think it works too
There was a problem hiding this comment.
ah right Types.ts contains the model card metadata type
There was a problem hiding this comment.
ok let's move the whole interfaces folder to the root of @huggingface/tasks ok?
|
lgtm ! |
Follow up to huggingface#297 & huggingface#317 (comment) 1. Moved deps to devDeps (cc: @coyotte508 please check) 2. Prettier was not running on svelte files. Upgrading prettier fixed the issue
Co-authored-by: beurkinger <beurkinger@users.noreply.github.com> Co-authored-by: Mishig <mishig25@users.noreply.github.com>
Follow up to huggingface/huggingface.js#297 & huggingface/huggingface.js#317 (comment) 1. Moved deps to devDeps (cc: @coyotte508 please check) 2. Prettier was not running on svelte files. Upgrading prettier fixed the issue
3 participants
https://kit.svelte.dev/docs/packaging