[Task Label & Icon] for Image-to-Video #317
Conversation
mishig25
force-pushed
the
task_icon_img_to_video
branch
from
4b03ee0 to
6764b0e
Compare
mishig25
changed the title
| export let classNames = ""; | ||
| </script> | ||
|
|
||
| <svg xmlns="http://www.w3.org/2000/svg" class={classNames} width="1em" height="1em" fill="none"><path fill="currentColor" fill-rule="evenodd" d="M1.43 1.2h6.63a.7.7 0 0 1 .7.7v4.44a.79.79 0 0 0-.34-.08h-.36V1.9H1.43v3.55l.9-.9a.7.7 0 0 1 .99 0l1.74 1.74a.79.79 0 0 0-.51.47L2.82 5.04l-1.4 1.4v2.09H4.5v.7H1.43a.7.7 0 0 1-.7-.7V1.9a.7.7 0 0 1 .7-.7ZM6.8 5.94l.32.32H5.5l.32-.32a.7.7 0 0 1 .99 0ZM6.2 4.52a1.05 1.05 0 1 1-1.17-1.75A1.05 1.05 0 0 1 6.2 4.52Zm-.4-1.16a.35.35 0 1 0-.38.58.35.35 0 0 0 .39-.58Zm3.9 5.16 1.57-1.26v3.14L9.7 9.15V10a.79.79 0 0 1-.79.79H5.77a.79.79 0 0 1-.79-.79V7.65a.79.79 0 0 1 .79-.78H8.9a.79.79 0 0 1 .79.78v.87Zm-3.93-.87v2.36H8.9V7.65H5.77Z" clip-rule="evenodd"/></svg> |
There was a problem hiding this comment.
@coyotte508 I think the formatter from #297 is not configured properly?
Shouldn't it be multline like
There was a problem hiding this comment.
hm yes maybe there's an issue with svelte files
mishig25
changed the title
packages/tasks/src/const.ts
Outdated
| "image-segmentation": ["transformers", "transformers.js"], | ||
| "image-to-image": [], | ||
| "image-to-text": ["transformers.js"], | ||
| "image-to-video": [], // TODO: diffusers will soon support image-to-video |
There was a problem hiding this comment.
Let's add it already, it will be ready this week
| "image-to-video": [], // TODO: diffusers will soon support image-to-video | |
| "image-to-video": ["diffusers"], |
There was a problem hiding this comment.
@osanseviero shouldn't this line also be diffusers ?
There was a problem hiding this comment.
for another PR, we should probably unify packages/tasks/src/const.ts & packages/widgets/src/lib/interfaces/LibrariesToTasks.ts. Updating both of them is error-prone
There was a problem hiding this comment.
yep TBH i didn't even remember the tasks/src/const.ts one
There was a problem hiding this comment.
They are different though. LibrariesToTasks defines which tasks are supported by the Inference API for the specific library. This file is automatically generated by a GitHub Actions workflow in api-inference-community. const.ts is about library support, not specific to Inference API
| "image-segmentation": getData("image-segmentation", imageSegmentation), | ||
| "image-to-image": getData("image-to-image", imageToImage), | ||
| "image-to-text": getData("image-to-text", imageToText), | ||
| "image-to-video": undefined, |
There was a problem hiding this comment.
Just a question to help me understand how it works, would creating an entry in tasks/data and populating it here would be enough to have the task listed in https://huggingface.co/tasks ?
There was a problem hiding this comment.
That's it, yes
for now the sync between this repo and the hub is'nt active (needs https://github.com/huggingface/moon-landing/pull/8158 + a follow-up PR)
but once it's active yes (there will be some stuff like publishing/updating packages but it can be automated by tooling)
Follow up to huggingface#297 & huggingface#317 (comment) 1. Moved deps to devDeps (cc: @coyotte508 please check) 2. Prettier was not running on svelte files. Upgrading prettier fixed the issue
Follow up to huggingface/huggingface.js#297 & huggingface/huggingface.js#317 (comment) 1. Moved deps to devDeps (cc: @coyotte508 please check) 2. Prettier was not running on svelte files. Upgrading prettier fixed the issue
This is how it looks