-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.14 #1381
Prepare for 0.14 #1381
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage ? 83.78%
=======================================
Files ? 48
Lines ? 4903
Branches ? 0
=======================================
Hits ? 4108
Misses ? 795
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…_hub into prepare-for-0.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good to me! I've quickly verified and it seems like this won't impact transformers
. Let's remember to still launch the full test suite in downstream libraries to ensure nothing breaks.
I'll do so for transformres
once this PR is merged in!
Thanks for the review! As said in the PR description, I tried to take care of the breaking changes in (I'm merging it btw) |
Great, will give it a try now and report here ASAP |
Remove deprecated methods:
set_access_token
unset_access_token
read_from_credential_store
write_to_credential_store
erase_from_credential_store
All of those are related to git credentials management. The preferred methods are not
set_git_credentials
andunset_git_credential
. Their main advantage is to respect the user preferences in term of git credential helper instead of assuminggit-credential-store
should be used. Read #1051 and #1138 for more details.I also took the opportunity of this PR to refactor some tests that were using
set_access_token
.set_access_token
was use in other HF repos. However, it was only for testing purposes and seemed to be legacy copy-pasted code (i.e. I don't except a lot of third-party libraries to use it). Here are the PRs to fix that:datasets
: Remove set_access_token usage + fail tests if FutureWarning datasets#5623transformers
: Remove set_access_token usage + fail tests if FutureWarning transformers#22051hffs
: Remove use ofset_access_token
in tests + small refacto hffs#15