Fix relative symlinks in cache #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Failing tests are unrelated to this PR (should be fixed/skipped by #1381). |
Wauplin
commented
Mar 13, 2023
| @@ -558,7 +558,7 @@ def cached_download( | |||
| token: Union[bool, str, None] = None, | |||
| local_files_only: bool = False, | |||
| legacy_cache_layout: bool = False, | |||
| ) -> Optional[str]: # pragma: no cover | |||
There was a problem hiding this comment.
unrelated to the fix so I can remove it if you strongly feel against it but otherwise I'll keep it (it just fix a type annotation, without any breaking change)
LysandreJik
approved these changes
Mar 13, 2023
|
@LysandreJik thanks for carefully reviewing it! I'll make a patch release |
Wauplin
added a commit
that referenced
this pull request
Mar 13, 2023
* fix relative symlinks in cache * fix test * fix test on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release introduced a bug in the cache (because of removing relative symlinks). I first removed the relative symlinks because we are now creating symlinks to any directory (not only within the cache). So let's use absolute paths everywhere.
This PR fixes the bug.
Reported in #1388 and huggingface/diffusers#2614. Also on discord.
(bug introduced by #1360)