Hide CommitOperationAdd's internal attributes
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariosasko
changed the title
CommitOperation's internal attributesCommitOperationAdd's internal attributes
Wauplin
reviewed
Oct 5, 2023
mariosasko
force-pushed
the
commitoperationadd-hide-internal-attributes
branch
from
0d258b6 to
810f169
Compare
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Lucain <lucainp@gmail.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
==========================================
+ Coverage 82.42% 82.48% +0.05%
==========================================
Files 62 62
Lines 7244 7262 +18
==========================================
+ Hits 5971 5990 +19
+ Misses 1273 1272 -1
☔ View full report in Codecov by Sentry. |
Wauplin
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks for making the change @mariosasko! Will merge it now that CI is ✔️
Wauplin
added a commit
that referenced
this pull request
Oct 10, 2023
* Hide `CommitOperationAdd`'s internal attributes * Update src/huggingface_hub/_commit_api.py Co-authored-by: Lucain <lucainp@gmail.com> * Style --------- Co-authored-by: Lucain <lucainp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that IDEs stop displaying them in the auto-complete