Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide CommitOperationAdd's internal attributes #1716

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Hide CommitOperationAdd's internal attributes #1716

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
810f169
Hide `CommitOperationAdd`'s internal attributes
mariosasko Oct 5, 2023
c84cea3
Update src/huggingface_hub/_commit_api.py
mariosasko Oct 6, 2023
0e67884
Style
mariosasko Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/huggingface_hub/_commit_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,22 +137,18 @@ class CommitOperationAdd:
upload_info: UploadInfo = field(init=False, repr=False)

# Internal attributes
_upload_mode: Optional[UploadMode] = None # set to "lfs" or "regular" once known
_is_uploaded: bool = False # set to True once the file has been upload as LFS
_is_committed: bool = False # set to True once the file has been committed
_upload_mode: Optional[UploadMode] = field(
init=False, repr=False, default=None
) # set to "lfs" or "regular" once known
_is_uploaded: bool = field(
init=False, repr=False, default=False
) # set to True once the file has been uploaded as LFS
_is_committed: bool = field(init=False, repr=False, default=False) # set to True once the file has been committed

def __post_init__(self) -> None:
"""Validates `path_or_fileobj` and compute `upload_info`."""
self.path_in_repo = _validate_path_in_repo(self.path_in_repo)

# Validate `_is_uploaded` and `_upload_mode` cannot be set by user
if self._is_uploaded is not False:
raise ValueError("Attribute `_is_uploaded` cannot be set manually.")
if self._upload_mode is not None:
raise ValueError("Attribute `_upload_mode` cannot be set manually.")
if self._is_committed is not False:
raise ValueError("Attribute `_is_committed` cannot be set manually.")

# Validate `path_or_fileobj` value
if isinstance(self.path_or_fileobj, Path):
self.path_or_fileobj = str(self.path_or_fileobj)
Expand Down
Loading