-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize environment variables #1786
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the little table, great job! 👍
so it's harmonizing to transformers, right? (i.e. where do those |
It's about harmonizing between themselves. To avoid having |
Other than that lgtm |
I'm fine with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for doing the work here @Wauplin
Looks good to me. Let's make sure we update in transformers and others
Thanks for the review! I'll merge now.
Yes definitely! I'll take care of it once released. |
From a discussion started by @thomwolf on slack (private link) cc @clefourrier @LysandreJik as well.
This PR fixes this by making all environments prefixed either by
HF_
orHF_HUB_
.IMO, this will be particularly impactful for
HF_TOKEN
andHF_CACHE
that were previously not intuitive.4 environment variables have been modified:
HUGGINGFACE_HUB_CACHE
HF_HUB_CACHE
HUGGINGFACE_ASSETS_CACHE
HF_ASSETS_CACHE
HUGGING_FACE_HUB_TOKEN
HF_TOKEN
HUGGINGFACE_HUB_VERBOSITY
HF_HUB_VERBOSITY
Backward compatibility is of course kept. No warning triggered if a legacy variable is used. If both the legacy and replacement variables are set on the machine, the newest (replacement) variable is kept.
Once this PR is merged and released, my plan will be to harmonize environment variables in the HF-ecosystem as well, starting with the Python libraries (transformers, datasets, diffusers, evaluate,...). But the goal is also to harmonize with JS, Rust and C# libraries when applicable.