Expose HF_HOME in constants
#1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
julien-c
approved these changes
Nov 14, 2023
| os.getenv( | ||
| "HF_HOME", | ||
| os.path.join(os.getenv("XDG_CACHE_HOME", default_home), "huggingface"), | ||
| ) | ||
| ) | ||
| hf_cache_home = HF_HOME # for backward compatibility. TODO: remove this in 1.0.0 |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
HF_HOMEenv variable is parsed but not exposed as ahuggingface_hubconstant. Let's expose it to harmonize things in other libraries.I am currently making a cleanup of the environment variables in the HF ecosystem, and especially
transformers(following up after #1786).I realized
transformersanddatasetsneed to know theHF_HOMEdirectory to store python modules. At the moment the parsing is done individually in those libraries. Let's harmonize that by defining aHF_HOMEconstant in huggingface_hub directly -instead of lowercasedhf_cache_home.I am tempted to make a new
0.19.2release once this is merged so that it can directly be integrated in transformers/datasets.