fix tqdm_class argument of subclass of tqdm #3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @hanouticelina |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
May 27, 2025
| ignore_patterns: Optional[Union[List[str], str]] = None, | ||
| max_workers: int = 8, | ||
| tqdm_class: Optional[base_tqdm] = None, | ||
| tqdm_class: Optional[type[base_tqdm]] = None, |
There was a problem hiding this comment.
Suggested change
| tqdm_class: Optional[type[base_tqdm]] = None, | |
| tqdm_class: Optional[Type[base_tqdm]] = None, |
and import Type from typing to make it work with python 3.8 (generic types was introduced in Python 3.9)
There was a problem hiding this comment.
Done. CI should be green later.
andyxning
force-pushed
the
fix_tqdm_class_argument_of_subclass_of_tqdm
branch
from
353b3ea to
9b270dd
Compare
andyxning
force-pushed
the
fix_tqdm_class_argument_of_subclass_of_tqdm
branch
from
9b270dd to
43d7f0b
Compare
|
@bot /style |
|
Style fixes have been applied. View the workflow run here. |
|
@hanouticelina sorry for the interrupt, when can this PR be released in a new version? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc of
tqdm_classargument,tqdm_classshould accept any class that are subclass oftqdm.