-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[MISC] bump huggingface_hub pkg to 0.33.0 #19547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] bump huggingface_hub pkg to 0.33.0 #19547
Conversation
Signed-off-by: Andy Xie <andy.xning@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @andyxning, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the huggingface_hub
dependency to version 0.33.0. The primary goal is to resolve a static analysis issue that occurred when using custom tqdm
subclasses, by incorporating a fix from the upstream library.
Highlights
- Dependency Upgrade: I've upgraded the
huggingface_hub
package version requirement across the project's dependency files. - Static Analysis Fix: This upgrade specifically includes a fix from
huggingface_hub
PR #3111, which addresses a static check error related to passing customtqdm
subclasses. - Related Dependency: As part of the dependency resolution for the test requirements, the
hf-xet
version was also updated.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates the huggingface-hub
dependency to version 0.33.0
in requirements/common.txt
, requirements/test.in
, and requirements/test.txt
. Please ensure that the changes do not introduce any compatibility issues or regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The ci failures seem flakes, can you help merge this manually? |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
bump huggingface_hub version to 0.33.0 to include huggingface/huggingface_hub#3111.
Thus custom tqdm subclass as a argument should not be reported as an error in static check.

Test Plan
NA
Test Result
NA
(Optional) Documentation Update