Rename the env variable HF_ENDPOINT.
#819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @SBrandeis since your made the initial modification so you are aware of this name change. Is it OK to change the name here ? |
|
Yes @Narsil that is fine |
Narsil
commented
Apr 5, 2022
src/huggingface_hub/hf_api.py
Outdated
| @@ -467,7 +467,7 @@ def erase_from_credential_store(username=None): | |||
| class HfApi: | |||
| def __init__(self, endpoint=None): | |||
| self.endpoint = ( | |||
| endpoint if endpoint is not None else os.getenv("HF_ENDPOINT", ENDPOINT) | |||
| endpoint if endpoint is not None else ENDPOINT | |||
There was a problem hiding this comment.
I removed this, since ENDPOINT is already inheriting from the same env variable, to reduce the potential from divergence.
|
The documentation is not available anymore as the PR was closed or merged. |
osanseviero
approved these changes
Apr 5, 2022
adrinjalali
approved these changes
Apr 5, 2022
|
Thanks for the fix @Narsil . It'd be nice if for future PRs you'd create the feature branches on your fork rather than the main repo 😊 |
Ok, thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves consistency across HF ecosystem.
https://github.com/huggingface/transformers/blob/c595b6e6a90c29242c9dbfeecc5b132fe2e3d1f4/src/transformers/utils/hub.py#L110
https://github.com/huggingface/datasets/blob/8c5f27889657a1a6a7203b2f054bd0ceffce2178/src/datasets/config.py#L24
Fixes #798