Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the env variable HF_ENDPOINT. #819

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Rename the env variable HF_ENDPOINT. #819

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e0e3cc
Rename the env variable `HF_ENDPOINT`.
Narsil Apr 5, 2022
ce93d2e
Reuse `ENDPOINT` constant to reduce name clashes.
Narsil Apr 5, 2022
dd9b5d2
Quality.
Narsil Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/huggingface_hub/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
os.environ.get("HUGGINGFACE_CO_STAGING", "NO").upper() in ENV_VARS_TRUE_VALUES
)

ENDPOINT = os.getenv("HF_HUB_URL") or (
ENDPOINT = os.getenv("HF_ENDPOINT") or (
"https://moon-staging.huggingface.co" if _staging_mode else "https://huggingface.co"
)

Expand Down
2 changes: 1 addition & 1 deletion src/huggingface_hub/hf_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def erase_from_credential_store(username=None):
class HfApi:
def __init__(self, endpoint=None):
self.endpoint = (
endpoint if endpoint is not None else os.getenv("HF_ENDPOINT", ENDPOINT)
endpoint if endpoint is not None else ENDPOINT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this, since ENDPOINT is already inheriting from the same env variable, to reduce the potential from divergence.

)

def login(self, username: str, password: str) -> str:
Expand Down