✨ Programmatic API for the community tab #930
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
SBrandeis
force-pushed
the
discussion-api
branch
from
3774f49 to
4567a6b
Compare
SBrandeis
force-pushed
the
discussion-api
branch
from
f55c987 to
4979ff0
Compare
SBrandeis
changed the title
SBrandeis
requested review from
LysandreJik,
osanseviero and
julien-c
and removed request for
LysandreJik
There was a problem hiding this comment.
Very impressive PR. Thanks for working on this @SBrandeis, really love the documentation you wrote to explain everything.
That the diff and history are accessible through this API are pretty nifty.
|
|
||
| Returns: [`DiscussionWithDetails`] | ||
|
|
||
| <Tip> |
There was a problem hiding this comment.
I think that so far, through the codebase we have been using <Tip> quite a bit because Raises: wasn't implemented. I would continue with <Tip> in this PR, and offer a PR that switches everything to Raises:.
The only place where I can see some Raises: are in the lfs.py file that was modified recently and which are not visible in the documentation, AFAIK.
Co-authored-by: Julien Chaumond <julien@huggingface.co>
|
this should be ready to merge, do you want to give it a final look then merge @Wauplin? |
There was a problem hiding this comment.
Hey @SBrandeis, I reviewed the PR which got me to understand more how things are implemented 🙂 . A majority of the comments are just typos since I read all the documentation you've written. For other parts, I'm just curious on if I understood things correctly.
Programmatic API to interact with discussions and pull requests on the Hub:
etc etc