Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocalib moss #486

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

Cadene
Copy link
Collaborator

@Cadene Cadene commented Oct 26, 2024

What this does

Explain what this PR does. Feel free to tag your PR with the appropriate label(s).

Examples:

Title Label
Fixes #[issue] (πŸ› Bug)
Adds new dataset (πŸ—ƒοΈ Dataset)
Optimizes something (⚑️ Performance)

How it was tested

Explain/show how you tested your changes.

Examples:

  • Added test_something in tests/test_stuff.py.
  • Added new_feature and checked that training converges with policy X on dataset/environment Y.
  • Optimized some_function, it now runs X times faster than previously.

How to checkout & try? (for the reviewer)

Provide a simple way for the reviewer to try out your changes.

Examples:

DATA_DIR=tests/data pytest -sx tests/test_stuff.py::test_something
python lerobot/scripts/train.py --some.option=true

SECTION TO REMOVE BEFORE SUBMITTING YOUR PR

Note: Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.

Note: Before submitting this PR, please read the contributor guideline.

@Cadene Cadene marked this pull request as ready for review October 26, 2024 09:57
@alexander-soare alexander-soare self-requested a review October 26, 2024 10:00
Copy link
Contributor

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@alexander-soare alexander-soare merged commit 55e4ff6 into main Oct 26, 2024
7 checks passed
@alexander-soare alexander-soare deleted the user/rcadene/2024_10_26_fix_autocalib_moss branch October 26, 2024 10:15
vmayoral pushed a commit to vmayoral/lerobot that referenced this pull request Nov 17, 2024
astroyat pushed a commit to astroyat/lerobot that referenced this pull request Nov 23, 2024
Cadene added a commit that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants