-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows #494
Conversation
Looks good to me! Thanks for the improvements to print + comments ;) |
Style check failing. Run our pre-commit ;)
|
Oh you mean I'm actually supposed to follow the instructions for contributing 😅 I thought "no way this won't pass" but here we are... updates made! |
OK @Cadene this one isn't on me my test passed 😄 System.IO.IOException: No space left on device : '/home/runner/runners/2.320.0/_diag/Worker_20241101-143253-utc.log' If this is something you want me to have a look at let me know, I've done lots of infra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@brainwavecoder9 If you find any other compatibility issue, please let me know. I will be more reactive this time ;) |
What this does
Windows uses COM ports not what is expected for Linux/Mac. This commit adds support for Windows OS. It does this by:
There is a dependency (
pyserial
) but it is already in the environment so no changes there. Once the port is identified it can be added to the.yaml
the same as it is today. Although it will be referenced differently (e.g.,COM7
vs./dev/ttyACM
) the rest of the functionality still works.How it was tested
Successful in Windows environment, and theoretically won't affect others, but does need to be confirmed before merge.
How to checkout & try? (for the reviewer)
No change to existing process. To use, simply execute the existing script, e.g.,
python lerobot/scripts/find_motors_bus_port.py