Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about precedence of custom tasks over default ones in registry #466

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Dec 19, 2024

EDIT: See comment below: #466 (comment)

Fix warning about precedence of custom tasks over default ones in registry.

Currently, custom tasks are overwriting default ones, wheres the warning/comment says the opposite.

Fix precedence of default tasks over custom ones in registry.

Currently, custom tasks are overwriting default ones.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
Copy link
Member Author

I am wondering why default tasks have precedence over custom ones: I would expect that if a user creates a custom task with the same name as a default one, they would expect to overwrite the default one.

@NathanHB
Copy link
Member

wait, not sure I follow, from the code It seems like custom tasks are overwriting the default ones right ?

@albertvillanova
Copy link
Member Author

albertvillanova commented Dec 19, 2024

Yes, but the docs say the opposite:

Defaults tasks should overwrite custom tasks

logger.warning(
f"Following tasks ({intersection}) exists both in the default and custom tasks. Will use the default ones on conflict."
)

@NathanHB
Copy link
Member

You are right custom tasks should overwrite default ones I think

@albertvillanova
Copy link
Member Author

I am fixing the comment/warning instead.

@albertvillanova albertvillanova changed the title Fix precedence of default tasks over custom ones in registry Fix warning about precedence of custom tasks over default ones in registry Dec 20, 2024
@NathanHB NathanHB merged commit 264f3f8 into huggingface:main Dec 20, 2024
3 checks passed
@albertvillanova albertvillanova deleted the fix-task-registry branch December 21, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants