-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning about precedence of custom tasks over default ones in registry #466
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I am wondering why default tasks have precedence over custom ones: I would expect that if a user creates a custom task with the same name as a default one, they would expect to overwrite the default one. |
wait, not sure I follow, from the code It seems like custom tasks are overwriting the default ones right ? |
Yes, but the docs say the opposite:
lighteval/src/lighteval/tasks/registry.py Lines 150 to 152 in 988fa94
|
You are right custom tasks should overwrite default ones I think |
I am fixing the comment/warning instead. |
EDIT: See comment below: #466 (comment)
Fix warning about precedence of custom tasks over default ones in registry.
Currently, custom tasks are overwriting default ones, wheres the warning/comment says the opposite.
Fix precedence of default tasks over custom ones in registry.Currently, custom tasks are overwriting default ones.