Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about precedence of custom tasks over default ones in registry #466

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Fix warning about precedence of custom tasks over default ones in registry #466

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8125ea2
Fix precedence of default tasks over custom ones in registry
albertvillanova Dec 19, 2024
e261c39
Merge branch 'main' into fix-task-registry
albertvillanova Dec 19, 2024
ad1ce89
Revert "Fix precedence of default tasks over custom ones in registry"
albertvillanova Dec 19, 2024
ff9a497
Fix comment/warning about precedence of custom over default tasks
albertvillanova Dec 20, 2024
4b65050
Merge branch 'main' of github.com:huggingface/lighteval into fix-task…
albertvillanova Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lighteval/tasks/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ def task_registry(self):
intersection = set(default_tasks_registry.keys()).intersection(set(custom_tasks_registry.keys()))
if len(intersection) > 0:
logger.warning(
f"Following tasks ({intersection}) exists both in the default and custom tasks. Will use the default ones on conflict."
f"Following tasks ({intersection}) exists both in the default and custom tasks. Will use the custom ones on conflict."
)

# Defaults tasks should overwrite custom tasks
# Custom tasks overwrite defaults tasks
return {**default_tasks_registry, **custom_tasks_registry}

@property
Expand Down
Loading