Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uv env path + details #188

Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix uv env path + details #188

merged 3 commits into from
Feb 5, 2025

Conversation

edbeeching
Copy link
Collaborator

#91 broke the slurm scripts, this PR updates them and fixes a bug with pushing details

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a turbo nit

@lewtun
Copy link
Member

lewtun commented Feb 5, 2025

I'm merging since I need this for #196

@lewtun lewtun merged commit 3fd56dc into main Feb 5, 2025
1 check passed
@lewtun lewtun deleted the uv-slurm-fixes branch February 5, 2025 22:59
GitMonkey0 pushed a commit to GitMonkey0/open-r1 that referenced this pull request Feb 24, 2025
* fix uv env path + details

* Update slurm/grpo.slurm

---------

Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants