Add GPQA Diamond and fix evaluation deps #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
changed the title
lewtun
commented
Feb 6, 2025
| export LD_LIBRARY_PATH=$(python -c "import site; print(site.getsitepackages()[0] + '/nvidia/nvjitlink/lib')"):$LD_LIBRARY_PATH | ||
| ``` | ||
|
|
||
| This will also install PyTorch `v2.5.1` and it is **very important** to use this version since the vLLM binaries are compiled for it. You can then install the remaining dependencies for your specific use case via `pip install -e .[LIST OF MODES]`. For most contributors, we recommend: | ||
|
|
||
| ```shell | ||
| pip install -e ".[dev]" | ||
| GIT_LFS_SKIP_SMUDGE=1 uv pip install -e ".[dev]" --link-mode=copy |
There was a problem hiding this comment.
Needed because uv cannot install lighteval otherwise due to some LFS file conflict
There was a problem hiding this comment.
Ah, I had this issue, I had reverted back to pip, glad you fixed it.
lewtun
commented
Feb 6, 2025
| lighteval vllm $MODEL_ARGS "custom|$TASK|0|0" \ | ||
| --custom-tasks src/open_r1/evaluate.py \ | ||
| --use-chat-template \ | ||
| --system-prompt="Please reason step by step, and put your final answer within \boxed{}." \ |
There was a problem hiding this comment.
Not needed for the DeepSeek models (gives ~1 point gain if included)
edbeeching
reviewed
Feb 6, 2025
edbeeching
reviewed
Feb 6, 2025
lewtun
commented
Feb 6, 2025
setup.py
Outdated
| @@ -53,17 +53,17 @@ | |||
| "huggingface-hub[cli]>=0.19.2,<1.0", | |||
| "isort>=5.12.0", | |||
| "liger_kernel==0.5.2", | |||
| "lighteval @ git+https://github.com/huggingface/lighteval.git@0e462692436e1f0575bdb4c6ef63453ad9bde7d4#egg=lighteval[math]", | |||
| "math-verify>=0.3.3", # Used for math verification in grpo | |||
| "lighteval @ git+https://github.com/huggingface/lighteval.git@3c9b0c9dde6718b23ef5b0f4960355f0d494bdfc#egg=lighteval[math]", | |||
There was a problem hiding this comment.
Bump to latest commit once vllm fix for DDP is merged: huggingface/lighteval#541
There was a problem hiding this comment.
done it's 86f62259f105ae164f655e0b91c92a823a742724
edbeeching
approved these changes
Feb 6, 2025
GitMonkey0
pushed a commit
to GitMonkey0/open-r1
that referenced
this pull request
Feb 24, 2025
* Add GPQA Diamond * Add table * Fix README * Up * Fixes * Ignore logs * Fix * Pin deps * Fix GRPO * Add Llama 70B tabels * Restore dp * Pin lighteval * Use bfloat16 * Tune table * Add note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GPQA diamond and various important fixes for evaluation (parsing & incompat between latest
vllmandlighteval). I've also unified the Slurm scripts for evaluation so we don't have multiple ways to eval models.TODO