-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ia3 and adalora support #809
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
huggingface/peft#1540 fixed adalora rank==0 issue in inference load model. |
update peft to 0.10.0 which contains huggingface/peft#1540 |
a77bbba
to
3540ec8
Compare
adalora + deepspeed zero3 finetune fix in peft huggingface/peft#1625 |
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
IA3 finetune with "--use_flash_attention" need PR fix in huggingface/peft#1634. since q, k, v should has some data type in FusedSDPA.apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PEFT v0.10, there was an issue with higher memory consumption from PEFT v0.7: #590
Let me try to see if that works.
We're still having an issue with Falcon-180b and more recent versions of PEFT. Let me see how we can do. |
try #895 and it could fix falcon 180b issue |
@sywangyi LGTM! Can you share a command for both ia3 and adalora to make sure I can run them please? |
Hi, @regisss . you could use "--peft_type ia3" for IA3 and "--peft_type adalora" for adalora in run_lora_clm.py command for alpaca dataset like
|
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
* Add ia3 and adalora support (huggingface#809) Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> * Fix failure in Llama-70B-FSDP test * Fix peft files --------- Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
* Add ia3 and adalora support (huggingface#809) Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> * Fix failure in Llama-70B-FSDP test * Fix peft files --------- Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
* Add ia3 and adalora support (huggingface#809) Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> * Fix failure in Llama-70B-FSDP test * Fix peft files --------- Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
What does this PR do?
Fixes # (issue)
Before submitting