-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bf16 model type issue for ia3 #1634
Conversation
@BenjaminBossan please help review. |
if set torch_dtype is bfloat16 in model.from_pretained(), all adapter layers after get_peft_model(xxx) should be bfloat16 as well. fix issue in ia3 and adalora, also ia3 forward return dtype should be aligned with the base_layer.forward() output. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, those changes to correctly enable bf16 look good. I'll request another review by the co-maintainers just to be sure.
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@pacman100 Could you please check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sywangyi, for the fixes!
No description provided.