Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest #1707

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Pin pytest #1707

merged 2 commits into from
Feb 21, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Feb 21, 2024

As per title, avoid the CI to fail due to a deprecated function that was removed in in pytest===8.0

see huggingface/transformers#29154

see e.g. https://github.com/huggingface/optimum/actions/runs/7968197590/job/21752079137

@JingyaHuang
Copy link
Contributor

pytest 8.0.0 shall work I think, it breaks from 8.0.1 released last Friday.

@fxmarty fxmarty requested review from JingyaHuang and removed request for JingyaHuang February 21, 2024 12:47
@fxmarty
Copy link
Contributor Author

fxmarty commented Feb 21, 2024

@JingyaHuang thank you

Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxmarty fxmarty merged commit 3321e56 into huggingface:main Feb 21, 2024
54 of 59 checks passed
young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
* pin pytest

* pin to <=8.0.0 as requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants