BaseConfig update for transformers>=4.22.0 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the base class (PretrainedConfig)
michaelbenayoun
force-pushed
the
fix_base_config_push_to_hub
branch
from
577a744
to
72759ba
Compare
michaelbenayoun
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
echarlaix
reviewed
Sep 16, 2022
optimum/configuration_utils.py
Outdated
|
|
||
| # That config file may point us toward another config file to use. | ||
| if "configuration_files" in config_dict: | ||
| configuration_file = cls.get_configuration_file(config_dict["configuration_files"]) |
There was a problem hiding this comment.
We should call cls.get_configuration_file here (see), so you shouldn't remove get_config_dict()
There was a problem hiding this comment.
You're right, thanks!
…entation as the base class (PretrainedConfig)" This reverts commit 5907b00.
michaelbenayoun
changed the title
echarlaix
reviewed
Sep 16, 2022
echarlaix
reviewed
Sep 20, 2022
Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
echarlaix
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
BaseConfigclass to synchronize with the updates performed on thetransformers.PretrainedConfig, and fixes the issue induced by thetransformers4.22 release, breaking the currentBaseConfig.push_to_hubmethod.