Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseConfig update for transformers>=4.22.0 #386

Merged
merged 13 commits into from
Sep 22, 2022
Merged

BaseConfig update for transformers>=4.22.0 #386

merged 13 commits into from
Sep 22, 2022

Commits on Sep 16, 2022

  1. Fix BaseConfig to make push_to_hub work again

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    f03bb56 View commit details
    Browse the repository at this point in the history

  2. Update BaseConfig.get_configuration_file docstring to match transformers

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    e898407 View commit details
    Browse the repository at this point in the history

  3. Remove BaseConfig.get_config_dict since it is the same implementation… 

    … as the base class (PretrainedConfig)
    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    5907b00 View commit details
    Browse the repository at this point in the history

  4. Update BaseConfig._get_config_dict and BaseConfig.to_dict

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    da64e7f View commit details
    Browse the repository at this point in the history

  5. Update BaseConfig.from_dict

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    72759ba View commit details
    Browse the repository at this point in the history

  6. Add requirement on transformers version in setup.py

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    e7102fa View commit details
    Browse the repository at this point in the history

  7. Style fix

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    225f13c View commit details
    Browse the repository at this point in the history

  8. Revert "Remove BaseConfig.get_config_dict since it is the same implem… 

    …entation as the base class (PretrainedConfig)"

This reverts commit 5907b00.
    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    9d74adf View commit details
    Browse the repository at this point in the history

  9. Re-add BaseConfig.get_config_dict as it is actually useful

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    2e41820 View commit details
    Browse the repository at this point in the history

  10. Make BaseConfig compatible with transformers <= 4.21.0

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7d170f8 View commit details
    Browse the repository at this point in the history

  11. Add todo comment

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    f0fa460 View commit details
    Browse the repository at this point in the history

  12. Use cached_file instead of hf_hub_download for transformers < 4.22

    @michaelbenayoun
    michaelbenayoun committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    8292875 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Update minimum transformers required version 

    Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
    @michaelbenayoun @echarlaix
    michaelbenayoun and echarlaix authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a49a2a4 View commit details
    Browse the repository at this point in the history