FIX: Multitask prompt tuning with other tuning init

[BenjaminBossan]

This is WIP, do not merge.

I attempted to fix #1082. While adding tests for the bug, I discovered that I could not make prompt_tuning_init != RANDOM to work. Maybe I'm using it wrong, but I'm not sure what to change.

Tests are now passing, this is ready for review @pacman100 @younesbelkada

[BenjaminBossan]

ping @mayank31398

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

[BenjaminBossan]

Another friendly ping @mayank31398

[mayank31398]

oops, hey @BenjaminBossan
will take a look over the weekend

[mayank31398]

FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_1_AVERAGE_SOURCE_TASKS - ValueError: task_ids cannot be None
FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_2_EXACT_SOURCE_TASK - ValueError: task_ids cannot be None
FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_3_ONLY_SOURCE_SHARED - ValueError: task_ids cannot be None

is this not expected?
these methods require task_ids parameter for forward pass or generate function

[BenjaminBossan]

these methods require task_ids parameter for forward pass or generate function

Yes, but the point is how do I pass them correctly? I tried this and it doesn't work:

https://github.com/huggingface/peft/pull/1144/files#diff-46602edfe9ad4dd646762de8e946d4e66a92d70968702a38bddd7a56f078abc7R284

Probably I'm using it wrong but I'm not sure how :)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

[BenjaminBossan]

Gentle ping @mayank31398

[mayank31398]

@BenjaminBossan It seems to be working fine for me.
Ignore the failing test for bf16 (I am on a Mac and that doesn't support bf16).

[mayank31398]

I merge main branch into the branch and then ran it. The test seems to pass for me

[mayank31398]

Can you try my branch: https://github.com/mayank31398/peft/tree/fix-multitask-prompt-tuning-other-inits

[BenjaminBossan]

I merge main branch into the branch and then ran it. The test seems to pass for me

Strange. I also merged the main branch and as you can see, CI is still red. The failing tests are:

FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_3_ONLY_SOURCE_SHARED - ValueError: task_ids cannot be None
FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_0_TEXT - OSError: None is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'
If this is a private repository, make sure to pass a token having permission to this repo either by logging in with `huggingface-cli login` or by passing `token=<your_token>`
FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_1_AVERAGE_SOURCE_TASKS - ValueError: task_ids cannot be None
FAILED tests/test_multitask_prompt_tuning.py::MultiTaskPromptTuningTester::test_generate_text_2_EXACT_SOURCE_TASK - ValueError: task_ids cannot be None

[mayank31398]

@BenjaminBossan ok, I did a fresh conda env install and now I am able to replicate your issue
For some reason, it was not picking my source install.
Fixing this right now :)

[mayank31398]

@BenjaminBossan fixed. Opened PR against your branch: BenjaminBossan#8

[BenjaminBossan]

Thanks @mayank31398, this has fixed the failing tests!

[mayank31398]

@BenjaminBossan @pacman100 can we merge this soon? 🤗

[BenjaminBossan]

Still waiting for a review :D

[pacman100]

Thank you @BenjaminBossan and @mayank31398 for fixing Multitask prompt tuning to work with non-random init configs!