[Tests] Add bitsandbytes installed from source on new docker images
#1275
Conversation
| - cron: "0 1 * * *" | ||
| push: | ||
| branches: | ||
| - add-peft-bnb-source-docker |
There was a problem hiding this comment.
to remove after testing
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I can confirm the built image points to the correct commit hash: https://github.com/huggingface/peft/actions/runs/7224973902/job/19687439574?pr=1275#step:6:6528 on bnb main |
younesbelkada
requested review from
BenjaminBossan,
Titus-von-Koeller,
pacman100 and
LysandreJik
| name: "Latest Peft GPU + bnb source [dev]" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Cleanup disk |
There was a problem hiding this comment.
I've never seen this before in a workflow file :O
There was a problem hiding this comment.
Yeah, I've copied that from transformers since I used to get some disk issues: https://github.com/huggingface/transformers/blob/main/.github/workflows/build-docker-images.yml#L25
| RUN source activate peft && \ | ||
| git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && \ | ||
| CUDA_VERSION=121 make cuda12x && \ | ||
| python setup.py develop | ||
|
|
||
| RUN source activate peft && \ | ||
| pip freeze | grep bitsandbytes |
There was a problem hiding this comment.
Steps like these could be combined to a single one to reduce the footprint.
There was a problem hiding this comment.
I've now refactored everthing based on your suggestions !
| RUN chsh -s /bin/bash | ||
| SHELL ["/bin/bash", "-c"] | ||
| RUN source activate peft && \ | ||
| python3 -m pip install --no-cache-dir optimum auto-gptq |
There was a problem hiding this comment.
Why a separate install of these packages here?
What does this PR do?
As per title, this will make life much easier for bnb developpers. I propose to create two separate docker images, both with bnb installed from source and run PEFT + transformers slow tests on daily basis, similarly as what we do currently with PEFT.
I can confirm building these docker images were successful on my local VM
cc @LysandreJik @Titus-von-Koeller @pacman100 @BenjaminBossan
Will first test if the workflow works fine here on GH