[bnb] Add bnb nightly workflow
#1282
Conversation
|
cc @Titus-von-Koeller FYI |
.github/workflows/nightly-bnb.yml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - add-bnb-tests |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Tests are all passing! https://github.com/huggingface/peft/actions/runs/7263175979/job/19787891361 |
younesbelkada
requested review from
BenjaminBossan,
pacman100 and
Titus-von-Koeller
| tests_core_single_gpu_bnb: | ||
| python -m pytest -m "single_gpu_tests and bitsandbytes" tests/test_common_gpu.py $(if $(IS_GITHUB_CI),--report-log "core_single_gpu.log",) | ||
|
|
||
| transformers_tests: |
There was a problem hiding this comment.
Why are we running this in PEFT? Just out of convenience or are these tests PEFT-related?
There was a problem hiding this comment.
it is just for convenience, I can add a comment to explain the intention
| "emoji": True | ||
| } | ||
| } | ||
| passed = [] |
There was a problem hiding this comment.
Since I'm lazy: Did you change any of the code in the main function, or is it just indented and the rest is the same?
There was a problem hiding this comment.
No no, I just idented it and the rest is all same
There was a problem hiding this comment.
Thank you @younesbelkada for adding the github workflow that runs everyday to make sure BNB integration in Transformers & PEFT are all good! LGTM 🚀.
| TEST_TYPE: "single_gpu_${{ matrix.docker-image-name }}" | ||
| container: | ||
| image: ${{ matrix.docker-image-name }} | ||
| options: --gpus all --shm-size "16gb" --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ -e NVIDIA_DISABLE_REQUIRE=true |
There was a problem hiding this comment.
We should use the value from NVIDIA_DISABLE_REQUIRE defined at the top. If we want to specify it explicitly in each command, then we don't need the one on the top?
There was a problem hiding this comment.
ah correct, i think I can remove it indeed
| source activate peft | ||
| make tests_examples_single_gpu_bnb | ||
|
|
||
| - name: Run core tests on single GPU |
There was a problem hiding this comment.
this won't run if the previous step fails. Do we want it this way?
| source activate peft | ||
| make tests_core_single_gpu_bnb | ||
|
|
||
| - name: Run transformers tests on single GPU |
| make transformers_tests | ||
|
|
||
| - name: Generate Report | ||
| if: always() |
|
Just a few tiny nits. And if I understand correctly, this new CI doesn't have an experiment run yet (before merge) 🤫. |
As per title, this PR adds the possibility to run peft tests on bitsandbytes compiled from source. It is a follow-up work from #1275