Throwing error when the configs fail JSON serialization #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Thank you! Conceptually looks good to me, but waiting a bit to merge:
- I think HUGGING_FACE_HUB_TOKEN will not be supported until #111 is merged (it's also in the
previewbranch you used). - I'm slightly concerned about potential clients of
HubApireceiving a different error now, but I suppose it should be ok. - I'd like to run the tests offline. We are planning to restore CI next week, hopefully, but meanwhile I'll do it locally.
pcuenca
reviewed
Aug 19, 2024
pcuenca
reviewed
Aug 19, 2024
|
Tests pass locally. Thanks again @kevin36524! |
|
That's great thanks @pcuenca |
pcuenca
added a commit
that referenced
this pull request
Sep 24, 2025
* Added error for JSON serialization errors * Fix merge commit --------- Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
pcuenca
added a commit
that referenced
this pull request
Sep 25, 2025
* feat: preview * Remove Random (#115) * Throwing error when the configs fail JSON serialization (#114) * Added error for JSON serialization errors * Fix merge commit --------- Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Allow archiving for Mac (#121) SPM dependencies are always compiled for the standard architectures, but Float16 is not available for `x86_64`. Thanks @joshnewnham for the workaround 🙌 * chore: strategic deletes avoid OOM * Remove RepetitionPenaltyWarper, fix build * Remove GenerationTests * Restore TokenizerError * Fix deprecation warnings in tests * Move transformers-cli to an example * Format * Relax requirements for main package But keep iOS 18 / macOS 15 for Core ML * Revert platform requirements * Relative package location plus comment * Mistral example: uv-ify and unpin * Remove obsolete GenerationTests again --------- Co-authored-by: FL33TW00D <FL33TW00D@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #112
Some HF models like mistral needs
HUGGING_FACE_HUB_TOKENto be set for the tokenizer and model config to be downloaded.Currently we are getting this generic error if the HUGGING_FACE_HUB_TOKEN is not set.
This PR add some nice error logs to give more hints to the user.
New Output