Stateful cache, MLTensor #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added error for JSON serialization errors * Fix merge commit --------- Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
SPM dependencies are always compiled for the standard architectures, but Float16 is not available for `x86_64`. Thanks @joshnewnham for the workaround 🙌
pcuenca
commented
Sep 24, 2025
Package.swift
Outdated
| let package = Package( | ||
| name: "swift-transformers", | ||
| platforms: [.iOS(.v16), .macOS(.v13)], | ||
| platforms: [.iOS("18.0"), .macOS("15.0")], |
There was a problem hiding this comment.
.v18 and .v15 not supported for manifests < Swift 6
There was a problem hiding this comment.
We could revert and conditionally exclude the Generation target instead
|
This is great! Cuts out a lot of cruft we don't need any more and we can repost about the Mistral 7B example (I still use it as a reference and even I struggle to find it!!) |
|
If we go forward, we can:
|
Merged
pcuenca
commented
Sep 25, 2025
| name: "transformers-cli", | ||
| platforms: [.iOS(.v18), .macOS(.v15)], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/huggingface/swift-transformers", branch: "main"), |
There was a problem hiding this comment.
Suggested change
| .package(url: "https://github.com/huggingface/swift-transformers", branch: "main"), | |
| .package(url: "https://github.com/huggingface/swift-transformers", from: "1.0.0"), |
to update
There was a problem hiding this comment.
We can use a relative import here
Suggested change
| .package(url: "https://github.com/huggingface/swift-transformers", branch: "main"), | |
| .package(path: "../../"), |
mattt
reviewed
Sep 25, 2025
But keep iOS 18 / macOS 15 for Core ML
This was referenced Sep 26, 2025
pcuenca
added a commit
that referenced
this pull request
Sep 26, 2025
Co-authored-by: Joshua Newman <joshnewnham@users.noreply.github.com> Co-authored-by: Yuduo Wu <6426433+1duo@users.noreply.github.com> Co-authored-by: Alejandro Isaza <alejandro-isaza@users.noreply.github.com> Co-authored-by: Aseem Wadhwa <aseemw@users.noreply.github.com> Reference: #257
pcuenca
added a commit
that referenced
this pull request
Sep 26, 2025
* feat: tokenizers and hub are the big sellers! * Update README.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update README.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * fix: add Mistral 7B example * Update README.md Co-authored-by: vb <vaibhavs10@gmail.com> * Update README.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Link to Core ML PR Co-authored-by: Joshua Newman <joshnewnham@users.noreply.github.com> Co-authored-by: Yuduo Wu <6426433+1duo@users.noreply.github.com> Co-authored-by: Alejandro Isaza <alejandro-isaza@users.noreply.github.com> Co-authored-by: Aseem Wadhwa <aseemw@users.noreply.github.com> Reference: #257 --------- Co-authored-by: FL33TW00D <FL33TW00D@users.noreply.github.com> Co-authored-by: Pedro Cuenca <pedro@huggingface.co> Co-authored-by: vb <vaibhavs10@gmail.com> Co-authored-by: Joshua Newman <joshnewnham@users.noreply.github.com> Co-authored-by: Yuduo Wu <6426433+1duo@users.noreply.github.com> Co-authored-by: Alejandro Isaza <alejandro-isaza@users.noreply.github.com> Co-authored-by: Aseem Wadhwa <aseemw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the preview branch on the current
main.What we gain:
MLTensorAPIMLShapedArray,MLMultiArray🥳)What we lose:
Some cleanup still needed.
Should we move forward with this? @mattt @FL33TW00D @Vaibhavs10 @ZachNagengast