feat: tokenizers and hub are the big sellers! #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
reviewed
Sep 26, 2025
| let tokens = try tokenizer.applyChatTemplate( | ||
| messages: [["role": "user", "content": "What's the weather in Paris?"]], | ||
| tools: [weatherTool] | ||
| ) |
There was a problem hiding this comment.
Perhaps we could write an additional, longer example using mlx for interaction with a language model, assuming there are tasks not fully undertaken by the mlx swift libraries.
There was a problem hiding this comment.
I think mlx-swift-examples only uses our tokenizers right? e.g https://github.com/ml-explore/mlx-swift-examples/blob/main/Libraries/MLXVLM/Models/Qwen25VL.swift#L733
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Vaibhavs10
reviewed
Sep 26, 2025
Co-authored-by: vb <vaibhavs10@gmail.com>
pcuenca
reviewed
Sep 26, 2025
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Joshua Newman <joshnewnham@users.noreply.github.com> Co-authored-by: Yuduo Wu <6426433+1duo@users.noreply.github.com> Co-authored-by: Alejandro Isaza <alejandro-isaza@users.noreply.github.com> Co-authored-by: Aseem Wadhwa <aseemw@users.noreply.github.com> Reference: #257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.