-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identifying backend compatibility versions #18817
Comments
Past CI - PyTorch 1.11 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - PyTorch 1.10 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - PyTorch 1.9 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - PyTorch 1.8 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - TensorFlow 2.8 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - TensorFlow 2.7 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - TensorFlow 2.6 (Patch release: v4.21.2 | b487096)General
Per model
|
Past CI - TensorFlow 2.5 (Patch release: v4.21.2 | b487096)General
Per model
|
I was trying to fix the kenlm issue, but I see it's correctly installed here and has been for a while. I guess it is an image issue? |
Hi @LysandreJik. In fact, Past CI use It's probably arguable if we should (or should not) include We can try with it in the next launch. |
I think we can add it, we've had it in the main file for 8 months so it's unlikely to cause an issue. Looking forward to the next launch! |
We are currently working on identifying the backend versions with which we are compatible and with which we want to be compatible. These backends are PyTorch and TensorFlow. We will be considering Flax at a later point in time.
The first step was to identify the number of failures in each PyTorch/TensorFlow version and was done in #18181.
Total number of tests: 38,991.
We're proposing to drop versions older than 2 years old and to work towards providing support (support = 0 tests failing) for versions we aim to support. We will drop support for older versions once we reach their two-year-old date.
Here is the proposed plan moving forward:
Work by @ydshieh and @LysandreJik
Some context and tips when working on Past CI
main
.errors.txt
where you can find more information to ease the fix process:errors.txt
to see the full trackback on the job run pages.errors.txt
.General
table, take a row whosestatus
is empty. Ideally, take the ones with higher value inno.
column.errors.txt
for theerror
in the picked row. You get information about the failed line, failed test, and the job link.status
column with a comment once a fix or a decision is made.utils/past_ci_versions.py
can help!main
branch. (This is particular confusing if you try to run the failed test without checking out to that commit.).main
branch, with the target framework version, it's very likely a fix exists onmain
that applies to the target framework version too.status
withfixed in #XXXXX
(if you know clearly that PR fixes that error)works for commits since **b487096**
- a commit sha (It's not always trivial to find out which PR fixed a particular error - especially when working with Past CI)kenlm
ordetectorn2
. We could just simply update thestatus
column withXXX not installed
.@unittest.skipIf
, and update the status liketorch._C issue -> works wth PT >= 11 Fixed in #19122
.see PT 11
in the reportstatus
column for older versions.status
with, for example,Vilt needs PT >= 1.10
.status
, we keep information tracked.The text was updated successfully, but these errors were encountered: