Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip BloomEmbeddingTest.test_embeddings for PT < 1.10 #19261

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Skip BloomEmbeddingTest.test_embeddings for PT < 1.10 #19261

merged 1 commit into from
Oct 10, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 30, 2022

What does this PR do?

The test BloomEmbeddingTest.test_embeddings will load a pretrained-model in bfloat16. For PyTorch < 1.10, we have

RuntimeError: "LayerNormKernelImpl" not implemented for 'BFloat16'

so let's skip it to keep Past CI clean

@ydshieh ydshieh mentioned this pull request Sep 30, 2022
Open
16 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 30, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

younesbelkada
younesbelkada approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this change and for taking care of compatibility on previous PyTorch versions! Also now the comments make more sense :-) !

LysandreJik
LysandreJik reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we also mention that this model is only available in torch 1.10+ when used with auto, or is that just specific to tests?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Oct 10, 2022

@LysandreJik For this case, it is specific to test (checkpoint is bigscience/bigscience-small-testing which has bfloat16 in the config file).

@ydshieh ydshieh merged commit cbb8a37 into main Oct 10, 2022
@ydshieh ydshieh deleted the fix_bloom_embed_test_in_pt_1_9 branch October 10, 2022 08:05
ajsanjoaquin pushed a commit to ajsanjoaquin/transformers that referenced this pull request Oct 12, 2022
@ydshieh @ajsanjoaquin
Skip BloomEmbeddingTest.test_embeddings for PyTorch < 1.10 (hugging…
3fea093 
…face#19261)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
@ydshieh @amyeroberts
Skip BloomEmbeddingTest.test_embeddings for PyTorch < 1.10 (hugging…
6968be0 
…face#19261)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik left review comments

@younesbelkada younesbelkada younesbelkada approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ydshieh @HuggingFaceDocBuilderDev @LysandreJik @sgugger @younesbelkada