PyTorch >= 1.7.0 and TensorFlow >= 2.4.0 #19016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Sep 14, 2022
|
That particular release broke weightnorm, and thus all audio models. |
setu4993
added a commit
to setu4993/convert-labse-tf-pt
that referenced
this pull request
Dec 29, 2022
Since Sept, HF Transformers doesn't support 1.6 and below. huggingface/transformers#19016
setu4993
added a commit
to setu4993/convert-labse-tf-pt
that referenced
this pull request
Dec 29, 2022
Since Sept, HF Transformers doesn't support 1.6 and below. huggingface/transformers#19016
setu4993
added a commit
to setu4993/convert-labse-tf-pt
that referenced
this pull request
Dec 29, 2022
* chore: Update `torch` version Since Sept, HF Transformers doesn't support 1.6 and below. huggingface/transformers#19016 * chore: Update to `pytest` v7 * chore: Move dev dependencies to group * chore: Support `transformers` v4.22.0 and above only * chore: Use py37 and above * chore: Add `ipython` for dev * style: Simplify isort config * chore: Bump `loguru` to v0.6.0 * chore: Update GitHub workflows * chore: Set `torch`, `tf`, `flax` as transient deps with HF transformers' extras * chore: Add `tensorflow-text` * chore: Update lock file * chore: Add `sentencepiece` extras * chore: Update lock file * style: Apply updated `isort` config * chore: Bump major version Breaking change since we're dropping py37 support here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed in #18817 we have decided that Transformers will support versions of PyTorch and TensorFlow for two years after their releases. As a result, Transformers can now assume a minimum version of 1.7.0 for PyTorch and 2.4.0 for TensorFlow. This PR enforces this in the setup and then simplifies a lot of code that was written to support older PyTorch versions.