-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade sentencepiece version #13564
upgrade sentencepiece version #13564
Conversation
Just double-checked, it's a Python 3.9 problem for the previous version. No problem with upgrading as long as all tests pass, but we won't know that until I fix a bug in the tests_fetcher utils, so stay tuned :-) |
In the meantime, you can run |
Can you rebase to integrate #13566 in your branch? It should then run all tests so we can double-check this doesn't break anything. |
Done 👍🏾 |
Discussing a bit more with Lysandre, I think we actually want >=0.0.91 and != 0.0.92 (which was the problematic version that made us pin sentencepiece). Do you mind adapting the PR? Thanks! |
You'll need to run |
Oh ok, I was wondering where it comes from... |
With a fressh venv with python3 on debian 11, here what a fresh pip install -e '.[dev]' results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes #13563
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.