Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBartTokenizer] remove dep on xlm-roberta tokenizer #15201

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[MBartTokenizer] remove dep on xlm-roberta tokenizer #15201

merged 1 commit into from
Jan 18, 2022

Conversation

patil-suraj
Copy link
Contributor

What does this PR do?

This PR makes MBartTokenizer and MBartTokenizerFast standalone and removes dependency on XLMRobertaTokenizer

sgugger
sgugger approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this!

LysandreJik
LysandreJik approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very nice!

@patil-suraj patil-suraj merged commit 2ae3be5 into huggingface:master Jan 18, 2022
@patil-suraj patil-suraj deleted the update-mbart-tok branch January 18, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patil-suraj @LysandreJik @sgugger