Add missing entries in mappings #16857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
commented
Apr 20, 2022
ydshieh
commented
Apr 20, 2022
ydshieh
commented
Apr 20, 2022
sgugger
reviewed
Apr 20, 2022
There was a problem hiding this comment.
All for adding missing entries, thanks a lot for this PR!
BUT:
- We should actually push more and more users to use the Auto classes API and not a specific model/tokenizer/feature extractor class. So big no on changing docstring that use
AutoTokenizer - The
ImageGPTchanges should probably go in their own PR
src/transformers/models/nystromformer/modeling_nystromformer.py
Outdated
Show resolved
Hide resolved
Without the changes, the I can add |
|
Yes, I think ImageGPT should be added in a separate PR since it requires additional changes. |
ydshieh
force-pushed
the
add_missing_items_in_mappings
branch
from
3860253 to
9da0c0d
Compare
|
The changes on ImageGPT are now on a separate PR: #16869 |
ydshieh
force-pushed
the
add_missing_items_in_mappings
branch
from
9da0c0d to
7ba782a
Compare
sgugger
approved these changes
Apr 21, 2022
ydshieh
force-pushed
the
add_missing_items_in_mappings
branch
from
7ba782a to
21ecef4
Compare
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* add missing entries in some mappings Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing entries in mappings:
TOKENIZER_MAPPING,FEATURE_EXTRACTOR_MAPPING,PROCESSOR_MAPPINGThe remaining models that don't have any
tokenizer/feature_extractor/processorare:which are expected to have no processor.