Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenizer class for XLMRobertaXL #19004

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix tokenizer class for XLMRobertaXL #19004

merged 1 commit into from
Sep 13, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 13, 2022

What does this PR do?

The 2 checkpoints for XLMRobertaXL use XLMRobertaTokenizer as tokenizer_class. In my PR #16857, I only checked _CONFIG_FOR_DOC in the modeling file at that time, and took RobertaTokenizer from there, which was wrong.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 13, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh requested a review from sgugger September 13, 2022 08:22
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

@ydshieh ydshieh merged commit 2886f7f into main Sep 13, 2022
@ydshieh ydshieh deleted the fix_auto_tokenizer_map branch September 13, 2022 12:04
sgugger pushed a commit that referenced this pull request Sep 13, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants