Exclude Databricks from notebook env only if the runtime is below 11.0 #17988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arg, our CI wasn't triggered properly. Could you try pushing an empty commit? |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Sure. I pushed a dummy commit removing a full stop in the comment. |
|
Didn't work again, there should be more tests spawning. You can do empty commits with |
|
Hmm still not sure why the CircleCI tests are skipped haha |
|
Okay managed to trigger it by pushing your branch inside the main fork of the repo. Let's just check all is green before merging, thanks for your patience! |
|
Thank you. Appreciate the quick feedback |
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
huggingface#17988) * Exclude Databricks from notebook env only if the runtime is below 11.0 * Dummy commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds additional check to
is_in_notebook()to returnFalsein Databricks only if the Databricks Runtime is below 11.0. In Databricks Runtime 11.0 and above, IPython kernel is the default Python execution engine. Therefore it should be more compatible with Jupyter notebook https://docs.databricks.com/notebooks/ipython-kernel.html#17406 (comment)
Additional Info
In Databricks Runtime 10.5 and earlier this is what the evaluation HTML output used to be. Therefore, we need to disable the notebook env.
In Databricks Runtime 11.0 with the default IPython kernel, the output looks similar to that in Jupyter notebook. Therefore, I believe we no longer need to disable the notebook env.
What does the value of
DATABRICKS_RUNTIME_VERSIONenvironment look like in Databricks notebook?Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.