Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Databricks from notebook env only if the runtime is below 11.0 #17988

Merged
merged 9 commits into from
Jul 1, 2022
Merged

Exclude Databricks from notebook env only if the runtime is below 11.0 #17988

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04ca6fe
Exclude Databricks from notebook env only if the runtime is below 11.0
davidheryanto Jul 1, 2022
e79e717
Dummy commit to trigger CI
davidheryanto Jul 1, 2022
58b85ad
Empty commit to trigger CI
davidheryanto Jul 1, 2022
64e6f0e
Empty commit to trigger CI
davidheryanto Jul 1, 2022
54c668f
Empty commit to trigger CI
davidheryanto Jul 1, 2022
e268618
Empty commit to trigger CI
davidheryanto Jul 1, 2022
bd10a73
Empty commit to trigger CI
davidheryanto Jul 1, 2022
5b073e3
Empty commit to trigger CI
davidheryanto Jul 1, 2022
26d9f1a
Empty commit to trigger CI
davidheryanto Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transformers/utils/import_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,9 @@ def is_in_notebook():
raise ImportError("console")
if "VSCODE_PID" in os.environ:
raise ImportError("vscode")
if "DATABRICKS_RUNTIME_VERSION" in os.environ:
if "DATABRICKS_RUNTIME_VERSION" in os.environ and os.environ["DATABRICKS_RUNTIME_VERSION"] < "11.0":
# Databricks Runtime 11.0 and above uses IPython kernel by default so it should be compatible with Jupyter notebook
# https://docs.microsoft.com/en-us/azure/databricks/notebooks/ipython-kernel
raise ImportError("databricks")

return importlib.util.find_spec("IPython") is not None
Expand Down