Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming issue with Image2TextGenerationPipeline #18864

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

OlivierDehaene
Copy link
Member

@OlivierDehaene OlivierDehaene commented Sep 2, 2022

What does this PR do?

Fixes naming issue with the Image2TextGenerationPipeline: naming was not consistent with other libraries.
See this message.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil, @sgugger

@OlivierDehaene OlivierDehaene changed the title Fix naming issue with ImageToText pipeline Fix naming issue with Image2TextGenrationPipeline Sep 2, 2022
@OlivierDehaene OlivierDehaene changed the title Fix naming issue with Image2TextGenrationPipeline Fix naming issue with Image2TextGenerationPipeline Sep 2, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The test failure seems unrelated to this PR.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing!

@sgugger sgugger merged commit 129d732 into huggingface:main Sep 2, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Co-authored-by: Olivier Dehaene <olivier@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants