Generate: inner decoding methods are no longer public #29437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the inner decoding methods (such as
greedy_search
) as private methods, with a deprecation warning.This will enable us to complete the following projects with fewer speed bumps:
torch.compile
: as seen in the PoC PR, a few interface pieces should be touched. E.g. Some special tokens can be alist
(e.g.eos_token_id
), which is not compile-friendly, and thustorch.tensor
should be used instead;generate
. Having multiple interfaces to maintain will constrain our ability to refactor the code.