Examples: check max_position_embeddings in the translation example
#29600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Mar 12, 2024
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
…29600) check max_position_embeddings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #28104
When a model with absolute position embeddings (such as Marian) is used in the translation training example, we must confirm that the input sequence length argument is smaller than its maximum sequence length. Otherwise, the data gets prepared with a larger sequence length, resulting in indexing errors.
This PR adds an informative exception, explaining what can be fixed when that happens :)
[Note: models with relative position embeddings, like T5, don't need this check. They can handle arbitrary sequence lengths.]