Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test ExamplesTests::test_run_translation #30281

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 17, 2024

What does this PR do?

ExamplesTests::test_run_translation.

@gante broke this in #29600 by adding a new check

        raise ValueError(
            f"`--max_source_length` is set to {data_args.max_source_length}, but the model only has"
            f" {model.config.max_position_embeddings} position encodings. Consider either reducing"
            f" `--max_source_length` to {model.config.max_position_embeddings} or using a model with larger position "
            "embeddings"
        )

@ydshieh ydshieh requested a review from gante April 17, 2024 04:03
@ydshieh ydshieh requested a review from amyeroberts April 17, 2024 04:06
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 05dab4e into main Apr 17, 2024
8 checks passed
@ydshieh ydshieh deleted the fix_translation_example_test branch April 17, 2024 09:46
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
ydshieh added a commit that referenced this pull request Apr 23, 2024
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
itazap pushed a commit that referenced this pull request May 14, 2024
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants