Fix accelerate kwargs for versions <0.28.0 #30086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Merging as the failing tests are unrelated and have been fixed upstream |
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* fix learning rate display issue in galore optimizer * fix kwarg in accelerate when using versions < 0.28.0 * this was supposed to be in the other PR whoops
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* fix learning rate display issue in galore optimizer * fix kwarg in accelerate when using versions < 0.28.0 * this was supposed to be in the other PR whoops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With this PR, the creation of an accelerate config breaks when using versions < 0.28.0. This is due to the introduction of this kwarg. My suggestion is to remove the kwarg either way (with
pop) as it's done for versions >=0.28.0.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr
@pacman100
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.