Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accelerate kwargs for versions <0.28.0 #30086

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Fix accelerate kwargs for versions <0.28.0 #30086

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64fde6b
fix learning rate display issue in galore optimizer
vasqu Apr 6, 2024
0d56634
fix kwarg in accelerate when using versions < 0.28.0
vasqu Apr 6, 2024
06d2184
this was supposed to be in the other PR whoops
vasqu Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4370,8 +4370,9 @@ def create_accelerator_and_postprocess(self):
even_batches=accelerator_config.pop("even_batches"),
use_seedable_sampler=accelerator_config.pop("use_seedable_sampler"),
)
# this would have been updated above, no need for it anymore
accelerator_config.pop("gradient_accumulation_kwargs")
# this would have been updated above, no need for it anymore
accelerator_config.pop("gradient_accumulation_kwargs")

args = {
"deepspeed_plugin": self.args.deepspeed_plugin,
"gradient_accumulation_plugin": gradient_accumulation_plugin,
Expand Down
Loading