-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolate pos encode vitmae #30657
Closed
bhuvanmdev
wants to merge
0
commits into
huggingface:main
from
bhuvanmdev:interpolate-pos-encode-vitmae
Closed
Interpolate pos encode vitmae #30657
bhuvanmdev
wants to merge
0
commits into
huggingface:main
from
bhuvanmdev:interpolate-pos-encode-vitmae
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
reviewed
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Overall looking good - just some small nits and implementation comments
11 tasks
I'm really Sorry, I got confused with one of my older branch and ended up polluting the PR. Will clean up the mess. Sorry for increasing your workload :( |
bhuvanmdev
force-pushed
the
interpolate-pos-encode-vitmae
branch
from
May 8, 2024 13:52
739d2f5
to
1872bde
Compare
bhuvanmdev
force-pushed
the
interpolate-pos-encode-vitmae
branch
from
May 9, 2024 17:33
bcf779a
to
71c1985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds interpolation capabilities for the tf and pytorch versions of vit_mae along with the test cases.
Addresses #30579 (vit_mae)
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested.
@amyeroberts