-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added interpolation for vitmae model in pytorch as well as tf. #30732
added interpolation for vitmae model in pytorch as well as tf. #30732
Conversation
irreugalr import fixed
Apologies, My previous PR got polluted with commits due to my negligence and lack of knowledge :( . I will make sure that is not repeated ever again. |
@bhuvanmdev It's OK, we're all learning :) If you hit tricky issues with the PR or git, feel free to ping on the PR and we can try to help (can't guarantee we'll know the answer though!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for working on this!
Just a few small comments
Done @amyeroberts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Just some nits on typing and docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this really useful feature to our vision models!
Just some small nits on the docstrings
doc fixes Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding and iterating on this!
For the quality checks - these are unrelated to this PR. We're currently battling to fix them. Once that's done I'll message here, we can rebase and this should be good to merge!
@bhuvanmdev Should be good to rebase! |
@amyeroberts should I sync this branch wrt to upstream main branch? |
@bhuvanmdev Yes please |
What does this PR do?
Adds interpolation capabilities for the tf and pytorch versions of vit_mae along with the test cases.
Addresses #30579 (vit_mae)
as discussed in #30657
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested.
@amyeroberts