Donut: fix generate call from local path
#31470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Jun 18, 2024
| # exception: Donut checkpoints have task-specific decoder starts and don't expect a BOS token. Note that the | ||
| # original checkpoints can't be detected through `self.__class__.__name__.lower()`, needing custom logic. | ||
| elif "donut" in self.__class__.__name__.lower() or ( | ||
| self.config.model_type == "vision-encoder-decoder" and "donut" in self.config.encoder.model_type.lower() |
There was a problem hiding this comment.
1st or clause: new checkpoints
2nd or clause: original donut checkpoints. self.name_or_path doesn't work for local files, self.config.encoder.model_type does
amyeroberts
approved these changes
Jun 18, 2024
| # exception: Donut checkpoints have task-specific decoder starts and don't expect a BOS token. Note that the | ||
| # original checkpoints can't be detected through `self.__class__.__name__.lower()`, needing custom logic. | ||
| elif "donut" in self.__class__.__name__.lower() or ( | ||
| self.config.model_type == "vision-encoder-decoder" and "donut" in self.config.encoder.model_type.lower() |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
itazap
pushed a commit
that referenced
this pull request
Jun 18, 2024
* local donut path fix * engrish * Update src/transformers/generation/utils.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
itazap
pushed a commit
that referenced
this pull request
Jun 20, 2024
* local donut path fix * engrish * Update src/transformers/generation/utils.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Donut has custom logic in
generate. Typically, we can detect certain architectures throughself.__class__.__name__, to then trigger custom logic. However, to detect donut's original checkpoints, whosemodel_typeandarchitecturesis incorrectly defined (e.g. here), we can't rely onself.__class__.__name__.The custom logic that was in place relied on the hub path, but that doesn't work for local file paths. This PR fixes it by clawing at the only piece of text saying "donut" in the original config 👀
cc @nbroad1881