Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donut: fix generate call from local path #31470

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Donut: fix generate call from local path #31470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9787c0
local donut path fix
gante Jun 18, 2024
7bb54af
engrish
gante Jun 18, 2024
f49c555
Update src/transformers/generation/utils.py
gante Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/transformers/generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,12 @@ def _prepare_decoder_input_ids_for_generation(
# no user input -> use decoder_start_token_id as decoder_input_ids
if decoder_input_ids is None:
decoder_input_ids = decoder_start_token_id
# exception: Donut checkpoints have task-specific decoder starts and don't expect a BOS token
elif self.config.model_type == "vision-encoder-decoder" and "donut" in self.name_or_path.lower():
# exception: Donut checkpoints have task-specific decoder starts and don't expect a BOS token. Note that the
# original checkpoints can't be detected through `self.__class__.__name__.lower()`, needing custom logic.
gante marked this conversation as resolved.
Show resolved Hide resolved
# See: https://github.com/huggingface/transformers/pull/31470
elif "donut" in self.__class__.__name__.lower() or (
self.config.model_type == "vision-encoder-decoder" and "donut" in self.config.encoder.model_type.lower()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st or clause: new checkpoints
2nd or clause: original donut checkpoints. self.name_or_path doesn't work for local files, self.config.encoder.model_type does

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

):
pass
elif self.config.model_type in ["whisper"]:
pass
Expand Down
Loading