Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GGUF for Mamba #34200

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

VladOS95-cyber
Copy link
Contributor

What does this PR do?

Add GGUF support for Mamba

Before submitting

Who can review?

Regarding the task @SunMarc @LysandreJik @ArthurZucker.

@VladOS95-cyber
Copy link
Contributor Author

Hi @SunMarc! This PR is ready for review, please, take a look.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work ! Left a question

tests/quantization/ggml/test_ggml.py Outdated Show resolved Hide resolved
@VladOS95-cyber VladOS95-cyber force-pushed the add-gguf-for-mamba branch 2 times, most recently from cb2d641 to 38e402c Compare October 21, 2024 17:11
@VladOS95-cyber
Copy link
Contributor Author

Hey @SunMarc! Do you have any questions or comments regarding this PR?

tests/quantization/ggml/test_ggml.py Outdated Show resolved Hide resolved
tests/quantization/ggml/test_ggml.py Outdated Show resolved Hide resolved
@VladOS95-cyber VladOS95-cyber force-pushed the add-gguf-for-mamba branch 5 times, most recently from bd11280 to 775024b Compare October 25, 2024 05:18
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into that ! LGTM !

@SunMarc SunMarc requested a review from LysandreJik October 25, 2024 11:29
@VladOS95-cyber VladOS95-cyber force-pushed the add-gguf-for-mamba branch 4 times, most recently from b8c95b9 to b2eee3b Compare October 28, 2024 12:55
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @VladOS95-cyber

@LysandreJik LysandreJik merged commit 5251fe6 into huggingface:main Oct 30, 2024
22 checks passed
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
* add mamba architecture for gguf

* add logic for weights conversion, some fixes and refactoring

* add lm_head layers, unit test refactoring

* more fixes for tests

* remove lm_head creation

* remove unused comments
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* add mamba architecture for gguf

* add logic for weights conversion, some fixes and refactoring

* add lm_head layers, unit test refactoring

* more fixes for tests

* remove lm_head creation

* remove unused comments
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* add mamba architecture for gguf

* add logic for weights conversion, some fixes and refactoring

* add lm_head layers, unit test refactoring

* more fixes for tests

* remove lm_head creation

* remove unused comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants